mart-w/kanidm
1
0
Fork 0
mirror of https://github.com/kanidm/kanidm.git synced 2025-02-23 20:47:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add code_challenge_methods_supported to OIDC discovery (#2525)

Browse source
This commit is contained in:
Firstyear 2024-02-15 09:17:08 +10:00 committed by GitHub
parent a315d8d440
commit 002ab13698
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
proto/src/oauth2.rs
View file

@ -350,6 +350,8 @@ pub struct OidcDiscoveryResponse {
pub request_uri_parameter_supported: bool,
#[serde(default = "require_request_uri_parameter_supported_default")]
pub require_request_uri_registration: bool,
pub code_challenge_methods_supported: Vec<PkceAlg>,
}
#[skip_serializing_none]

16
server/lib/src/idm/oauth2.rs
View file

@ -2305,6 +2305,17 @@ impl<'a> IdmServerProxyReadTransaction<'a> {
let claims_supported = None;
let service_documentation = Some(URL_SERVICE_DOCUMENTATION.clone());
let require_pkce = match &o2rs.type_ {
OauthRSType::Basic { enable_pkce, .. } => *enable_pkce,
OauthRSType::Public { .. } => true,
};
let code_challenge_methods_supported = if require_pkce {
vec![PkceAlg::S256]
} else {
Vec::with_capacity(0)
};
Ok(OidcDiscoveryResponse {
issuer,
authorization_endpoint,
@ -2344,6 +2355,7 @@ impl<'a> IdmServerProxyReadTransaction<'a> {
require_request_uri_registration: false,
op_policy_uri: None,
op_tos_uri: None,
code_challenge_methods_supported,
})
}
@ -4148,6 +4160,10 @@ mod tests {
assert!(!discovery.request_uri_parameter_supported);
assert!(!discovery.require_request_uri_registration);
assert!(!discovery.request_parameter_supported);
assert_eq!(
discovery.code_challenge_methods_supported,
vec![PkceAlg::S256]
)
}
#[idm_test]