mart-w/kanidm
1
0
Fork 0
mirror of https://github.com/kanidm/kanidm.git synced 2025-02-23 12:37:00 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCIM Sync Missing Annotation (#3300)

Browse source 
A missing serde annotion in SCIM Sync caused groups to fail to
sync unless they had a description. This resolves the failure
by adding the correct annotation to skip None fields in groups.
This commit is contained in:
Firstyear 2024-12-17 14:18:30 +10:00 committed by GitHub
parent eba8dff23a
commit 0b2f349aec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
proto/src/scim_v1/synch.rs
View file

@ -220,6 +220,7 @@ pub struct ScimExternalMember {
pub external_id: String, pub external_id: String,
} }
#[skip_serializing_none]
#[derive(Serialize, Deserialize, Debug, Clone)] #[derive(Serialize, Deserialize, Debug, Clone)]
#[serde(rename_all = "snake_case")] #[serde(rename_all = "snake_case")]
pub struct ScimSyncGroup { pub struct ScimSyncGroup {

2
tools/iam_migrations/freeipa/src/main.rs
View file

@ -942,7 +942,7 @@ fn ipa_to_scim_entry(
.build(); .build();
let scim_entry_generic: ScimEntry = scim_sync_person.try_into().map_err(|json_err| { let scim_entry_generic: ScimEntry = scim_sync_person.try_into().map_err(|json_err| {
error!(?json_err, "Unable to convert group to scim_sync_group"); error!(?json_err, "Unable to convert person to scim_sync_person");
})?; })?;
Ok(Some(scim_entry_generic)) Ok(Some(scim_entry_generic))

2
tools/iam_migrations/ldap/src/main.rs
View file

@ -633,7 +633,7 @@ fn ldap_to_scim_entry(
.build(); .build();
let scim_entry_generic: ScimEntry = scim_sync_person.try_into().map_err(|json_err| { let scim_entry_generic: ScimEntry = scim_sync_person.try_into().map_err(|json_err| {
error!(?json_err, "Unable to convert group to scim_sync_group"); error!(?json_err, "Unable to convert person to scim_sync_person");
})?; })?;
Ok(Some(scim_entry_generic)) Ok(Some(scim_entry_generic))