mart-w/kanidm
1
0
Fork 0
mirror of https://github.com/kanidm/kanidm.git synced 2025-02-23 12:37:00 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

client: read attestation CA list JSON from file (#3232)

Browse source 
instead of passing a giant blob of JSON as a command argument.
Before, it was not possible to allow all valid authenticators
certified by the FIDO Alliance because

fido-mds-list query -o "status gte valid"

outputs a JSON string longer than Linux allows for command
arguments.

Co-authored-by: Firstyear <william@blackhats.net.au>
This commit is contained in:
Be 2024-12-19 21:02:02 -06:00 committed by GitHub
parent 4f2eb8b5f8
commit 2174b9b251
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tools/cli/src/cli/group/account_policy.rs
View file

@ -113,12 +113,17 @@ impl GroupAccountPolicyOpt {
} }
GroupAccountPolicyOpt::WebauthnAttestationCaList { GroupAccountPolicyOpt::WebauthnAttestationCaList {
name, name,
attestation_ca_list_json, attestation_ca_list_json_file,
copt, copt,
} => { } => {
let client = copt.to_client(OpType::Write).await; let client = copt.to_client(OpType::Write).await;
let json = std::fs::read_to_string(attestation_ca_list_json_file).unwrap_or_else(|e| {
error!("Could not read attestation CA list JSON file {attestation_ca_list_json_file:?}: {e:?}");
std::process::exit(1);
});
if let Err(e) = client if let Err(e) = client
.group_account_policy_webauthn_attestation_set(name, attestation_ca_list_json) .group_account_policy_webauthn_attestation_set(name, &json)
.await .await
{ {
handle_client_error(e, copt.output_mode); handle_client_error(e, copt.output_mode);

2
tools/cli/src/opt/kanidm.rs
View file

@ -216,7 +216,7 @@ pub enum GroupAccountPolicyOpt {
#[clap(name = "webauthn-attestation-ca-list")] #[clap(name = "webauthn-attestation-ca-list")]
WebauthnAttestationCaList { WebauthnAttestationCaList {
name: String, name: String,
attestation_ca_list_json: String, attestation_ca_list_json_file: PathBuf,
#[clap(flatten)] #[clap(flatten)]
copt: CommonOpt, copt: CommonOpt,
}, },