mart-w/kanidm
1
0
Fork 0
mirror of https://github.com/kanidm/kanidm.git synced 2025-02-23 20:47:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Cleanup incorrect log errors of denied entries (#1577)

Browse source
This commit is contained in:
Firstyear 2023-04-27 15:38:45 +10:00 committed by GitHub
parent 33f0034b80
commit 49a767179c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
server/lib/src/server/access/mod.rs
View file

@ -210,6 +210,7 @@ pub trait AccessControlsTransaction<'a> {
let related_acp: Vec<(&AccessControlSearch, _)> = self.search_related_acp(&se.ident); let related_acp: Vec<(&AccessControlSearch, _)> = self.search_related_acp(&se.ident);
// For each entry. // For each entry.
let entries_is_empty = entries.is_empty();
let allowed_entries: Vec<_> = entries let allowed_entries: Vec<_> = entries
.into_iter() .into_iter()
.filter(|e| { .filter(|e| {
@ -233,7 +234,9 @@ pub trait AccessControlsTransaction<'a> {
.collect(); .collect();
if allowed_entries.is_empty() { if allowed_entries.is_empty() {
security_access!("denied ❌ - no entries were released"); if !entries_is_empty {
security_access!("denied ❌ - no entries were released");
}
} else { } else {
security_access!("allowed {} entries ✅", allowed_entries.len()); security_access!("allowed {} entries ✅", allowed_entries.len());
} }
@ -272,6 +275,7 @@ pub trait AccessControlsTransaction<'a> {
}; };
// For each entry. // For each entry.
let entries_is_empty = entries.is_empty();
let allowed_entries: Vec<_> = entries let allowed_entries: Vec<_> = entries
.into_iter() .into_iter()
.filter_map(|e| { .filter_map(|e| {
@ -321,7 +325,9 @@ pub trait AccessControlsTransaction<'a> {
.collect(); .collect();
if allowed_entries.is_empty() { if allowed_entries.is_empty() {
security_access!("reduced to empty set on all entries ❌"); if !entries_is_empty {
security_access!("reduced to empty set on all entries ❌");
}
} else { } else {
security_access!( security_access!(
"attribute set reduced on {} entries ✅", "attribute set reduced on {} entries ✅",