mart-w/kanidm
1
0
Fork 0
mirror of https://github.com/kanidm/kanidm.git synced 2025-02-23 20:47:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Clean up utils password rand generation. (#2727)

Browse source 
We previously used a "performance" optimisation in our password generation
that was likely not needed. This optimisation did *not* impact password
entropy or quality in the generation.

To improve clarity, swap to the Uniform distribution instead.
This commit is contained in:
Firstyear 2024-04-27 23:22:39 +10:00 committed by GitHub
parent 2e206b2488
commit 5ff482542b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
server/lib/src/utils.rs
View file

@ -1,6 +1,6 @@
use crate::prelude::*; use crate::prelude::*;
use hashbrown::HashSet; use hashbrown::HashSet;
use rand::distributions::Distribution; use rand::distributions::{Distribution, Uniform};
use rand::{thread_rng, Rng}; use rand::{thread_rng, Rng};
#[derive(Debug)] #[derive(Debug)]
@ -77,13 +77,11 @@ impl Distribution<char> for DistinctAlpha {
const GEN_ASCII_STR_CHARSET: &[u8] = b"ABCDEFGHJKLMNPQRSTUVWXYZ\ const GEN_ASCII_STR_CHARSET: &[u8] = b"ABCDEFGHJKLMNPQRSTUVWXYZ\
abcdefghjkpqrstuvwxyz\ abcdefghjkpqrstuvwxyz\
0123456789"; 0123456789";
// This probably needs to be checked for entropy/quality
loop { let range = Uniform::new(0, RANGE);
let var = rng.next_u32() >> (32 - 6);
if var < RANGE { let n = range.sample(rng);
return GEN_ASCII_STR_CHARSET[var as usize] as char; GEN_ASCII_STR_CHARSET[n as usize] as char
}
}
} }
} }