Review Feedback

This commit is contained in:
William Brown 2025-02-27 13:30:06 +10:00
parent 5b9aeda5b7
commit 6b5a924d05
3 changed files with 4 additions and 3 deletions
server
lib/src
constants
migration_data/dl10
testkit/src

View file

@ -8,6 +8,7 @@ pub const UUID_ADMIN: Uuid = uuid!("00000000-0000-0000-0000-000000000000");
pub const UUID_IDM_ADMINS: Uuid = uuid!("00000000-0000-0000-0000-000000000001");
pub const NAME_IDM_ADMINS: &str = "idm_admins";
pub const UUID_IDM_PEOPLE_PII_READ: Uuid = uuid!("00000000-0000-0000-0000-000000000002");
pub const NAME_IDM_PEOPLE_PII_READ: &str = "idm_people_pii_read";
pub const UUID_IDM_PEOPLE_WRITE_PRIV: Uuid = uuid!("00000000-0000-0000-0000-000000000003");
pub const UUID_IDM_GROUP_WRITE_PRIV: Uuid = uuid!("00000000-0000-0000-0000-000000000004");
pub const UUID_IDM_ACCOUNT_READ_PRIV: Uuid = uuid!("00000000-0000-0000-0000-000000000005");

View file

@ -173,7 +173,7 @@ lazy_static! {
/// Builtin IDM Group for granting elevated people (personal data) read permissions.
pub static ref BUILTIN_GROUP_PEOPLE_PII_READ: BuiltinGroup = BuiltinGroup {
name: "idm_people_pii_read",
name: NAME_IDM_PEOPLE_PII_READ,
description: "Builtin IDM Group for granting elevated people (personal data) read permissions.",
uuid: UUID_IDM_PEOPLE_PII_READ,
entry_managed_by: Some(UUID_IDM_ADMINS),

View file

@ -18,7 +18,7 @@ use kanidm_client::{KanidmClient, KanidmClientBuilder};
use kanidm_proto::internal::{Filter, Modify, ModifyList};
use kanidmd_core::config::{Configuration, IntegrationTestConfig};
use kanidmd_core::{create_server_core, CoreHandle};
use kanidmd_lib::prelude::Attribute;
use kanidmd_lib::prelude::{Attribute, NAME_SYSTEM_ADMINS};
use tokio::task;
pub const ADMIN_TEST_USER: &str = "admin";
@ -385,7 +385,7 @@ pub async fn login_put_admin_idm_admins(rsclient: &KanidmClient) {
#[allow(clippy::expect_used)]
rsclient
.idm_group_add_members("system_admins", &[ADMIN_TEST_USER])
.idm_group_add_members(NAME_SYSTEM_ADMINS, &[ADMIN_TEST_USER])
.await
.expect("Failed to add admin user to idm_admins")
}