Clippy

proto/src/scim_v1/server.rs

@@ -4,7 +4,7 @@ use super::ScimSshPublicKey;
 use crate::attribute::Attribute;
 use crate::internal::UiHint;
 use scim_proto::ScimEntryHeader;
-use serde::{Deserialize, Serialize};
+use serde::Serialize;
 use serde_with::{base64, formats, hex::Hex, serde_as, skip_serializing_none};
 use std::collections::{BTreeMap, BTreeSet};
 use time::format_description::well_known::Rfc3339;
@@ -28,7 +28,7 @@ pub struct ScimEntryKanidm {
     pub attrs: BTreeMap<Attribute, ScimValueKanidm>,
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
+#[derive(Serialize, Debug, Clone, ToSchema)]
 pub enum ScimAttributeEffectiveAccess {
     /// All attributes on the entry have this permission granted
     Grant,
@@ -49,7 +49,7 @@ impl ScimAttributeEffectiveAccess {
     }
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
+#[derive(Serialize, Debug, Clone, ToSchema)]
 #[serde(rename_all = "camelCase")]
 pub struct ScimEffectiveAccess {
     /// The identity that inherits the effective permission
@@ -209,7 +209,7 @@ pub struct ScimOAuth2ClaimMap {
     pub values: BTreeSet<String>,
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, ToSchema)]
+#[derive(Serialize, Debug, Clone, PartialEq, Eq, ToSchema)]
 #[serde(rename_all = "camelCase")]
 pub struct ScimReference {
     pub uuid: Uuid,
@@ -258,7 +258,7 @@ pub enum ScimValueKanidm {
 }
 
 #[serde_as]
-#[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
+#[derive(Serialize, Debug, Clone, ToSchema)]
 pub struct ScimPerson {
     pub uuid: Uuid,
     pub name: String,

server/core/src/https/views/admin/persons.rs

@@ -102,7 +102,7 @@ pub(crate) async fn view_persons_get(
     VerifiedClientInformation(client_auth_info): VerifiedClientInformation,
 ) -> axum::response::Result<Response> {
     let persons = get_persons_info(state, &kopid, client_auth_info, domain_info.clone()).await?;
-    let persons_partial = PersonsPartialView { persons: persons };
+    let persons_partial = PersonsPartialView { persons };
 
     let push_url = HxPushUrl(Uri::from_static("/ui/admin/persons"));
     Ok(if is_htmx {

server/lib/src/server/mod.rs

@@ -993,7 +993,7 @@ pub trait QueryServerTransaction<'a> {
                 Ok(PartialValue::Refer(un))
             }
 
-            _ => return Err(OperationError::InvalidAttribute(attr.to_string())),
+            _ => Err(OperationError::InvalidAttribute(attr.to_string())),
         }
     }