Update schema check to be cleaner

src/lib/be/mod.rs

@@ -9,8 +9,8 @@ use serde_json;
 
 use audit::AuditScope;
 use entry::{Entry, EntryCommitted, EntryNew, EntryValid};
-use filter::{Filter, FilterValid};
 use error::OperationError;
+use filter::{Filter, FilterValid};
 
 mod idl;
 mod mem_be;
@@ -384,12 +384,12 @@ impl BackendWriteTransaction {
         Ok(())
     }
 
-    pub fn backup() -> Result<(), BackendError> {
+    pub fn backup(&self) -> Result<(), BackendError> {
         unimplemented!()
     }
 
     // Should this be offline only?
-    pub fn restore() -> Result<(), BackendError> {
+    pub fn restore(&self) -> Result<(), BackendError> {
         unimplemented!()
     }
 
@@ -763,5 +763,5 @@ mod tests {
             be.restore();
             be.backup();
         });
-    )
+    }
 }

src/lib/core.rs

@@ -2,8 +2,7 @@
 use actix::Actor;
 use actix_web::middleware::session::{self, RequestSession};
 use actix_web::{
-    error, http, middleware, App, Error, HttpMessage, HttpRequest,
+    error, http, middleware, App, Error, HttpMessage, HttpRequest, HttpResponse, Result, State,
-    HttpResponse, Result, State,
 };
 
 use bytes::BytesMut;
@@ -15,9 +14,7 @@ use super::config::Configuration;
 use super::event::{AuthEvent, CreateEvent, DeleteEvent, ModifyEvent, SearchEvent};
 use super::interval::IntervalActor;
 use super::log;
-use super::proto_v1::{
+use super::proto_v1::{AuthRequest, CreateRequest, DeleteRequest, ModifyRequest, SearchRequest};
-    AuthRequest, CreateRequest, DeleteRequest, ModifyRequest, SearchRequest,
-};
 use super::server;
 
 struct AppState {

src/lib/entry.rs

@@ -140,7 +140,7 @@ pub struct Entry<VALID, STATE> {
 }
 
 impl Entry<EntryInvalid, EntryNew> {
-    /*
+    #[cfg(test)]
     pub fn new() -> Self {
         Entry {
             // This means NEVER COMMITED
@@ -150,7 +150,6 @@ impl Entry<EntryInvalid, EntryNew> {
             attrs: BTreeMap::new(),
         }
     }
-    */
 
     // FIXME: Can we consume protoentry?
     pub fn from(e: &ProtoEntry) -> Self {

src/lib/filter.rs

@@ -4,7 +4,7 @@
 
 use error::SchemaError;
 use proto_v1::Filter as ProtoFilter;
-use schema::{SchemaReadTransaction};
+use schema::SchemaReadTransaction;
 use std::cmp::{Ordering, PartialOrd};
 use std::marker::PhantomData;
 

src/lib/plugins/base.rs

@@ -7,7 +7,7 @@ use entry::{Entry, EntryInvalid, EntryNew};
 use error::OperationError;
 use event::CreateEvent;
 use filter::Filter;
-use schema::{SchemaWriteTransaction};
+use schema::SchemaWriteTransaction;
 
 // TO FINISH
 /*

src/lib/plugins/mod.rs

@@ -1,9 +1,9 @@
 use audit::AuditScope;
-use be::{BackendWriteTransaction};
+use be::BackendWriteTransaction;
 use entry::{Entry, EntryInvalid, EntryNew};
 use error::OperationError;
 use event::CreateEvent;
-use schema::{SchemaWriteTransaction};
+use schema::SchemaWriteTransaction;
 
 mod base;
 mod protected;

src/lib/schema.rs

@@ -1,7 +1,7 @@
 use super::audit::AuditScope;
 use super::constants::*;
 // use super::entry::Entry;
-use super::error::{SchemaError, OperationError};
+use super::error::{OperationError, SchemaError};
 // use super::filter::Filter;
 use std::collections::HashMap;
 // Apparently this is nightly only?

src/lib/server.rs

@@ -319,6 +319,7 @@ impl<'a> QueryServerWriteTransaction<'a> {
         }
 
         // TODO: Rework this to be better.
+        /*
         let (norm_cand, invalid_cand): (
             Vec<Result<Entry<EntryValid, EntryNew>, _>>,
             Vec<Result<_, SchemaError>>,
@@ -342,6 +343,17 @@ impl<'a> QueryServerWriteTransaction<'a> {
                 Err(_) => panic!("Invalid data set state!!!"),
             })
             .collect();
+        */
+
+        let res: Result<Vec<Entry<EntryValid, EntryNew>>, SchemaError> = candidates
+            .into_iter()
+            .map(|e| e.validate(&self.schema))
+            .collect();
+
+        let norm_cand: Vec<Entry<EntryValid, EntryNew>> = match res {
+            Ok(v) => v,
+            Err(e) => return Err(OperationError::SchemaViolation(e)),
+        };
 
         let mut audit_be = AuditScope::new("backend_create");
         // We may change from ce.entries later to something else?
@@ -417,6 +429,8 @@ impl<'a> QueryServerWriteTransaction<'a> {
         // FIXME: This normalisation COPIES everything, which may be
         // slow.
 
+        /*
+
         let (norm_cand, invalid_cand): (
             Vec<Result<Entry<EntryValid, EntryCommitted>, _>>,
             Vec<Result<_, SchemaError>>,
@@ -445,6 +459,18 @@ impl<'a> QueryServerWriteTransaction<'a> {
             })
             .collect();
 
+        */
+
+        let res: Result<Vec<Entry<EntryValid, EntryCommitted>>, SchemaError> = candidates
+            .into_iter()
+            .map(|e| e.validate(&self.schema))
+            .collect();
+
+        let del_cand: Vec<Entry<_, _>> = match res {
+            Ok(v) => v,
+            Err(e) => return Err(OperationError::SchemaViolation(e)),
+        };
+
         let mut audit_be = AuditScope::new("backend_modify");
 
         let res = self
@@ -622,6 +648,7 @@ impl<'a> QueryServerWriteTransaction<'a> {
         // FIXME: This normalisation COPIES everything, which may be
         // slow.
 
+        /*
         let (norm_cand, invalid_cand): (
             Vec<Result<Entry<EntryValid, EntryCommitted>, _>>,
             Vec<Result<_, SchemaError>>,
@@ -646,6 +673,17 @@ impl<'a> QueryServerWriteTransaction<'a> {
                 Err(_) => panic!("Invalid data set state!!!"),
             })
             .collect();
+        */
+
+        let res: Result<Vec<Entry<EntryValid, EntryCommitted>>, SchemaError> = candidates
+            .into_iter()
+            .map(|e| e.validate(&self.schema))
+            .collect();
+
+        let norm_cand: Vec<Entry<_, _>> = match res {
+            Ok(v) => v,
+            Err(e) => return Err(OperationError::SchemaViolation(e)),
+        };
 
         // Now map out the Oks?
 
@@ -887,8 +925,7 @@ impl<'a> QueryServerWriteTransaction<'a> {
             // costly.
             .and_then(|_| {
                 // Backend Commit
-                be_txn.commit()
+                be_txn.commit().and_then(|_| {
-                .and_then(|_| {
                     // Schema commit: Since validate passed and be is good, this
                     // must now also be good.
                     schema.commit()
@@ -952,13 +989,9 @@ impl Handler<CreateEvent> for QueryServer {
 
             let qs_write = self.write();
 
-            qs_write.create(&mut audit, &msg)
+            qs_write
-                .and_then(|_| {
+                .create(&mut audit, &msg)
-                    qs_write.commit(&mut audit)
+                .and_then(|_| qs_write.commit(&mut audit).map(|_| OpResult {}))
-                        .map(|_| {
-                            OpResult {}
-                        })
-                })
         });
         // At the end of the event we send it for logging.
         self.log.do_send(audit);
@@ -976,13 +1009,9 @@ impl Handler<ModifyEvent> for QueryServer {
 
             let qs_write = self.write();
 
-            qs_write.modify(&mut audit, &msg)
+            qs_write
-                .and_then(|_| {
+                .modify(&mut audit, &msg)
-                    qs_write.commit(&mut audit)
+                .and_then(|_| qs_write.commit(&mut audit).map(|_| OpResult {}))
-                        .map(|_| {
-                            OpResult {}
-                        })
-                })
         });
         self.log.do_send(audit);
         res
@@ -999,13 +1028,9 @@ impl Handler<DeleteEvent> for QueryServer {
 
             let qs_write = self.write();
 
-            qs_write.delete(&mut audit, &msg)
+            qs_write
-                .and_then(|_| {
+                .delete(&mut audit, &msg)
-                    qs_write.commit(&mut audit)
+                .and_then(|_| qs_write.commit(&mut audit).map(|_| OpResult {}))
-                        .map(|_| {
-                            OpResult {}
-                        })
-                })
         });
         self.log.do_send(audit);
         res
@@ -1036,13 +1061,9 @@ impl Handler<PurgeEvent> for QueryServer {
             audit_log!(audit, "Begin purge tombstone event {:?}", msg);
             let qs_write = self.write();
 
-            let res = qs_write.purge_tombstones(&mut audit)
+            let res = qs_write
-                .map(|_| {
+                .purge_tombstones(&mut audit)
-                    qs_write.commit(&mut audit)
+                .map(|_| qs_write.commit(&mut audit).map(|_| OpResult {}));
-                        .map(|_| {
-                            OpResult {}
-                        })
-                });
             audit_log!(audit, "Purge tombstones result: {:?}", res);
             res.expect("Invalid Server State");
         });
@@ -1069,7 +1090,7 @@ mod tests {
     use super::super::audit::AuditScope;
     use super::super::be::{Backend, BackendTransaction};
     use super::super::entry::{Entry, EntryCommitted, EntryInvalid, EntryNew, EntryValid};
-    use super::super::error::OperationError;
+    use super::super::error::{OperationError, SchemaError};
     use super::super::event::{
         CreateEvent, DeleteEvent, ModifyEvent, ReviveRecycledEvent, SearchEvent,
     };
@@ -1260,7 +1281,12 @@ mod tests {
                     String::from("anusaosu"),
                 )]),
             );
-            assert!(server_txn.modify(audit, &me_inv_f) == Err(OperationError::SchemaViolation));
+            assert!(
+                server_txn.modify(audit, &me_inv_f)
+                    == Err(OperationError::SchemaViolation(
+                        SchemaError::InvalidAttribute
+                    ))
+            );
 
             // Mod is invalid to schema
             let me_inv_m = ModifyEvent::from_filter(
@@ -1270,7 +1296,12 @@ mod tests {
                     String::from("anusaosu"),
                 )]),
             );
-            assert!(server_txn.modify(audit, &me_inv_m) == Err(OperationError::SchemaViolation));
+            assert!(
+                server_txn.modify(audit, &me_inv_m)
+                    == Err(OperationError::SchemaViolation(
+                        SchemaError::InvalidAttribute
+                    ))
+            );
 
             // Mod single object
             let me_sin = ModifyEvent::from_filter(