From a0944b8601d5892d5f5b263dc15362fbe6c328ba Mon Sep 17 00:00:00 2001 From: George Wu Date: Sat, 19 Oct 2024 00:00:29 -0700 Subject: [PATCH] Log HTTP Not Found (404) as info log level. (#3119) --- server/core/src/https/trace.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/server/core/src/https/trace.rs b/server/core/src/https/trace.rs index 81a70e9c4..8836659b3 100644 --- a/server/core/src/https/trace.rs +++ b/server/core/src/https/trace.rs @@ -1,6 +1,6 @@ //! Reimplementation of tower-http's DefaultMakeSpan that only runs at "INFO" level for our own needs. -use axum::http::Request; +use axum::http::{Request, StatusCode}; use kanidm_proto::constants::KOPID; use sketching::event_dynamic_lvl; use tower_http::LatencyUnit; @@ -83,7 +83,11 @@ impl tower_http::trace::OnResponse for DefaultOnResponseKanidmd { if response.status().is_redirection() { (Level::INFO, "client redirection sent") } else if response.status().is_client_error() { - (Level::WARN, "client error") // it worked, but there was an input error + if response.status() == StatusCode::NOT_FOUND { + (Level::INFO, "client error") + } else { + (Level::WARN, "client error") // it worked, but there was an input error + } } else { (Level::ERROR, "error handling request") // oh no the server failed }