From e98d60a96231314dd6dc812f55812b95dbf04971 Mon Sep 17 00:00:00 2001 From: Firstyear <william@blackhats.net.au> Date: Fri, 28 Feb 2025 18:30:59 +1000 Subject: [PATCH] Use lld by default on linux (#3477) * Use lld by default on linux --------- Co-authored-by: James Hodgkinson <james@terminaloutcomes.com> --- .cargo/config.toml | 11 +++++++++++ book/src/developers/readme.md | 32 ++++++++++---------------------- 2 files changed, 21 insertions(+), 22 deletions(-) create mode 100644 .cargo/config.toml diff --git a/.cargo/config.toml b/.cargo/config.toml new file mode 100644 index 000000000..cc2c47df9 --- /dev/null +++ b/.cargo/config.toml @@ -0,0 +1,11 @@ +# The default ld from glibc is impossibly slow and consumes huge amounts of +# memory. We use lld by default which often is twice as fast for significantly +# less ram consumption. + +[target.x86_64-unknown-linux-gnu] +linker = "clang" +rustflags = ["-C", "link-arg=-fuse-ld=lld", "-Ctarget-cpu=native"] + +[target.aarch64-unknown-linux-gnu] +linker = "clang" +rustflags = ["-C", "link-arg=-fuse-ld=lld", "-Ctarget-cpu=native"] diff --git a/book/src/developers/readme.md b/book/src/developers/readme.md index b628fb825..1c4273a9d 100644 --- a/book/src/developers/readme.md +++ b/book/src/developers/readme.md @@ -100,21 +100,16 @@ You will need [rustup](https://rustup.rs/) to install a Rust toolchain. ### SUSE / OpenSUSE +> NOTE: clang and lld are required to build Kanidm due to performance issues with GCC/ld + You will need to install rustup and our build dependencies with: ```bash -zypper in rustup git libudev-devel sqlite3-devel libopenssl-3-devel libselinux-devel pam-devel systemd-devel tpm2-0-tss-devel +zypper in rustup git libudev-devel sqlite3-devel libopenssl-3-devel libselinux-devel \ + pam-devel systemd-devel tpm2-0-tss-devel clang lld make sccache ``` - You can then use rustup to complete the setup of the toolchain. -In some cases you may need to build other vendored components, or use an alternate linker. In these -cases we advise you to also install. - -```bash -zypper in clang lld make sccache -``` - You should also adjust your environment with: ```bash @@ -123,25 +118,16 @@ export CC="sccache /usr/bin/clang" export CXX="sccache /usr/bin/clang++" ``` -And add the following to a cargo config of your choice (such as ~/.cargo/config), adjusting for cpu -arch - -```toml -[target.aarch64-unknown-linux-gnu] -linker = "clang" -rustflags = [ - "-C", "link-arg=-fuse-ld=lld", -] -``` - ### Fedora +> NOTE: clang and lld are required to build Kanidm due to performance issues with GCC/ld + You will need [rustup](https://rustup.rs/) to install a Rust toolchain. You will also need some system libraries to build this: ```text -systemd-devel sqlite-devel openssl-devel pam-devel +systemd-devel sqlite-devel openssl-devel pam-devel clang lld ``` Building the Web UI requires additional packages: @@ -152,12 +138,14 @@ perl-FindBin perl-File-Compare ### Ubuntu +> NOTE: clang and lld are required to build Kanidm due to performance issues with GCC/ld + You need [rustup](https://rustup.rs/) to install a Rust toolchain. You will also need some system libraries to build this, which can be installed by running: ```bash -sudo apt-get install libudev-dev libssl-dev libsystemd-dev pkg-config libpam0g-dev +sudo apt-get install libudev-dev libssl-dev libsystemd-dev pkg-config libpam0g-dev clang lld ``` Tested with Ubuntu 20.04 and 22.04.