mirror of
https://github.com/kanidm/kanidm.git
synced 2025-02-23 20:47:01 +01:00
Rework of auditing
This commit is contained in:
parent
56e4809c28
commit
eebc88765f
|
@ -18,6 +18,9 @@ path = "src/main.rs"
|
||||||
[dependencies]
|
[dependencies]
|
||||||
actix = "0.7"
|
actix = "0.7"
|
||||||
actix-web = "0.7"
|
actix-web = "0.7"
|
||||||
|
bytes = "0.4"
|
||||||
|
env_logger = "0.5"
|
||||||
|
|
||||||
|
|
||||||
tokio = "0.1"
|
tokio = "0.1"
|
||||||
futures = "0.1"
|
futures = "0.1"
|
||||||
|
|
116
src/audit.rs
Normal file
116
src/audit.rs
Normal file
|
@ -0,0 +1,116 @@
|
||||||
|
use actix::prelude::*;
|
||||||
|
use std::time::SystemTime;
|
||||||
|
|
||||||
|
#[macro_export]
|
||||||
|
macro_rules! audit_log {
|
||||||
|
($audit:expr, $($arg:tt)*) => ({
|
||||||
|
use std::fmt;
|
||||||
|
if cfg!(test) || cfg!(debug_assertions) {
|
||||||
|
print!("DEBUG AUDIT -> ");
|
||||||
|
println!($($arg)*)
|
||||||
|
}
|
||||||
|
$audit.raw_event(
|
||||||
|
fmt::format(
|
||||||
|
format_args!($($arg)*)
|
||||||
|
)
|
||||||
|
)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
|
struct AuditInner {
|
||||||
|
name: String,
|
||||||
|
time: SystemTime,
|
||||||
|
}
|
||||||
|
|
||||||
|
// This structure tracks and event lifecycle, and is eventually
|
||||||
|
// sent to the logging system where it's structured and written
|
||||||
|
// out to the current logging BE.
|
||||||
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
|
pub struct AuditEvent {
|
||||||
|
// vec of start/end points of various parts of the event?
|
||||||
|
// We probably need some functions for this. Is there a way in rust
|
||||||
|
// to automatically annotate line numbers of code?
|
||||||
|
events: Vec<AuditInner>,
|
||||||
|
}
|
||||||
|
|
||||||
|
// Allow us to be sent to the log subsystem
|
||||||
|
impl Message for AuditEvent {
|
||||||
|
type Result = ();
|
||||||
|
}
|
||||||
|
|
||||||
|
impl AuditEvent {
|
||||||
|
pub fn new() -> Self {
|
||||||
|
AuditEvent { events: Vec::new() }
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn start_event(&mut self, name: &str) {
|
||||||
|
self.events.push(AuditInner {
|
||||||
|
name: String::from(name),
|
||||||
|
time: SystemTime::now(),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn raw_event(&mut self, data: String) {
|
||||||
|
self.events.push(AuditInner {
|
||||||
|
name: data,
|
||||||
|
time: SystemTime::now(),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn end_event(&mut self, name: &str) {
|
||||||
|
self.events.push(AuditInner {
|
||||||
|
name: String::from(name),
|
||||||
|
time: SystemTime::now(),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::AuditEvent;
|
||||||
|
|
||||||
|
// Create and remove. Perhaps add some core details?
|
||||||
|
#[test]
|
||||||
|
fn test_audit_simple() {
|
||||||
|
let mut au = AuditEvent::new();
|
||||||
|
au.start_event("test");
|
||||||
|
au.end_event("test");
|
||||||
|
let d = serde_json::to_string_pretty(&au).unwrap();
|
||||||
|
println!("{}", d);
|
||||||
|
}
|
||||||
|
|
||||||
|
fn test_audit_nested_inner(au: &mut AuditEvent) {
|
||||||
|
au.start_event("inner");
|
||||||
|
au.end_event("inner");
|
||||||
|
}
|
||||||
|
|
||||||
|
// Test calling nested functions and getting the details added correctly?
|
||||||
|
#[test]
|
||||||
|
fn test_audit_nested() {
|
||||||
|
let mut au = AuditEvent::new();
|
||||||
|
au.start_event("test");
|
||||||
|
test_audit_nested_inner(&mut au);
|
||||||
|
au.end_event("test");
|
||||||
|
let d = serde_json::to_string_pretty(&au).unwrap();
|
||||||
|
println!("{}", d);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Test failing to close an event
|
||||||
|
#[test]
|
||||||
|
fn test_audit_no_close() {
|
||||||
|
let mut au = AuditEvent::new();
|
||||||
|
au.start_event("test");
|
||||||
|
au.start_event("inner");
|
||||||
|
let d = serde_json::to_string_pretty(&au).unwrap();
|
||||||
|
println!("{}", d);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Test logging
|
||||||
|
// specifically, logs should be sent to this struct and posted post-op
|
||||||
|
// rather that "during" the operation. They should be structured!
|
||||||
|
//
|
||||||
|
// IMO these should be structured as json?
|
||||||
|
#[test]
|
||||||
|
fn test_audit_logging() {}
|
||||||
|
}
|
|
@ -1,5 +1,4 @@
|
||||||
//! Db executor actor
|
//! Db executor actor
|
||||||
use actix::prelude::*;
|
|
||||||
|
|
||||||
use r2d2::Pool;
|
use r2d2::Pool;
|
||||||
use r2d2_sqlite::SqliteConnectionManager;
|
use r2d2_sqlite::SqliteConnectionManager;
|
||||||
|
@ -8,9 +7,9 @@ use rusqlite::NO_PARAMS;
|
||||||
use serde_json;
|
use serde_json;
|
||||||
// use uuid;
|
// use uuid;
|
||||||
|
|
||||||
|
use super::audit::AuditEvent;
|
||||||
use super::entry::Entry;
|
use super::entry::Entry;
|
||||||
use super::filter::Filter;
|
use super::filter::Filter;
|
||||||
use super::log::EventLog;
|
|
||||||
|
|
||||||
mod idl;
|
mod idl;
|
||||||
mod mem_be;
|
mod mem_be;
|
||||||
|
@ -41,10 +40,12 @@ struct IdEntry {
|
||||||
data: String,
|
data: String,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
pub enum BackendType {
|
pub enum BackendType {
|
||||||
Memory, // isn't memory just sqlite with file :memory: ?
|
Memory, // isn't memory just sqlite with file :memory: ?
|
||||||
SQLite,
|
SQLite,
|
||||||
}
|
}
|
||||||
|
*/
|
||||||
|
|
||||||
#[derive(Debug, PartialEq)]
|
#[derive(Debug, PartialEq)]
|
||||||
pub enum BackendError {
|
pub enum BackendError {
|
||||||
|
@ -52,14 +53,14 @@ pub enum BackendError {
|
||||||
}
|
}
|
||||||
|
|
||||||
pub struct Backend {
|
pub struct Backend {
|
||||||
log: actix::Addr<EventLog>,
|
|
||||||
pool: Pool<SqliteConnectionManager>,
|
pool: Pool<SqliteConnectionManager>,
|
||||||
}
|
}
|
||||||
|
|
||||||
// In the future this will do the routing betwene the chosen backends etc.
|
// In the future this will do the routing between the chosen backends etc.
|
||||||
impl Backend {
|
impl Backend {
|
||||||
pub fn new(log: actix::Addr<EventLog>, path: &str) -> Self {
|
pub fn new(audit: &mut AuditEvent, path: &str) -> Self {
|
||||||
// this has a ::memory() type, but will path == "" work?
|
// this has a ::memory() type, but will path == "" work?
|
||||||
|
audit.start_event("backend_new");
|
||||||
let manager = SqliteConnectionManager::file(path);
|
let manager = SqliteConnectionManager::file(path);
|
||||||
let builder1 = Pool::builder();
|
let builder1 = Pool::builder();
|
||||||
let builder2 = if path == "" {
|
let builder2 = if path == "" {
|
||||||
|
@ -92,15 +93,17 @@ impl Backend {
|
||||||
// Create the core db
|
// Create the core db
|
||||||
}
|
}
|
||||||
|
|
||||||
log_event!(log, "Starting DB worker ...");
|
audit_log!(audit, "Starting DB workers ...");
|
||||||
Backend {
|
audit.end_event("backend_new");
|
||||||
log: log,
|
Backend { pool: pool }
|
||||||
pool: pool,
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn create(&mut self, entries: &Vec<Entry>) -> Result<BackendAuditEvent, BackendError> {
|
pub fn create(
|
||||||
log_event!(self.log, "Begin create");
|
&mut self,
|
||||||
|
au: &mut AuditEvent,
|
||||||
|
entries: &Vec<Entry>,
|
||||||
|
) -> Result<BackendAuditEvent, BackendError> {
|
||||||
|
au.start_event("be_create");
|
||||||
|
|
||||||
let be_audit = BackendAuditEvent::new();
|
let be_audit = BackendAuditEvent::new();
|
||||||
// Start be audit timer
|
// Start be audit timer
|
||||||
|
@ -123,7 +126,7 @@ impl Backend {
|
||||||
})
|
})
|
||||||
.collect();
|
.collect();
|
||||||
|
|
||||||
log_event!(self.log, "serialising: {:?}", ser_entries);
|
audit_log!(au, "serialising: {:?}", ser_entries);
|
||||||
|
|
||||||
// THIS IS PROBABLY THE BIT WHERE YOU NEED DB ABSTRACTION
|
// THIS IS PROBABLY THE BIT WHERE YOU NEED DB ABSTRACTION
|
||||||
{
|
{
|
||||||
|
@ -145,13 +148,13 @@ impl Backend {
|
||||||
conn.execute("COMMIT TRANSACTION", NO_PARAMS).unwrap();
|
conn.execute("COMMIT TRANSACTION", NO_PARAMS).unwrap();
|
||||||
}
|
}
|
||||||
|
|
||||||
log_event!(self.log, "End create");
|
au.end_event("be_create");
|
||||||
// End the timer?
|
// End the timer?
|
||||||
Ok(be_audit)
|
Ok(be_audit)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Take filter, and AuditEvent ref?
|
// Take filter, and AuditEvent ref?
|
||||||
pub fn search(&self, filt: &Filter) -> Result<Vec<Entry>, ()> {
|
pub fn search(&self, au: &mut AuditEvent, filt: &Filter) -> Result<Vec<Entry>, ()> {
|
||||||
// Do things
|
// Do things
|
||||||
// Alloc a vec for the entries.
|
// Alloc a vec for the entries.
|
||||||
// FIXME: Make this actually a good size for the result set ...
|
// FIXME: Make this actually a good size for the result set ...
|
||||||
|
@ -161,6 +164,7 @@ impl Backend {
|
||||||
// possible) to create the candidate set.
|
// possible) to create the candidate set.
|
||||||
// Unlike DS, even if we don't get the index back, we can just pass
|
// Unlike DS, even if we don't get the index back, we can just pass
|
||||||
// to the in-memory filter test and be done.
|
// to the in-memory filter test and be done.
|
||||||
|
au.start_event("be_search");
|
||||||
|
|
||||||
let mut raw_entries: Vec<String> = Vec::new();
|
let mut raw_entries: Vec<String> = Vec::new();
|
||||||
{
|
{
|
||||||
|
@ -178,7 +182,7 @@ impl Backend {
|
||||||
})
|
})
|
||||||
.unwrap();
|
.unwrap();
|
||||||
for row in id2entry_iter {
|
for row in id2entry_iter {
|
||||||
println!("{:?}", row);
|
audit_log!(au, "raw entry: {:?}", row);
|
||||||
// FIXME: Handle this properly.
|
// FIXME: Handle this properly.
|
||||||
raw_entries.push(row.unwrap().data);
|
raw_entries.push(row.unwrap().data);
|
||||||
}
|
}
|
||||||
|
@ -200,6 +204,7 @@ impl Backend {
|
||||||
})
|
})
|
||||||
.collect();
|
.collect();
|
||||||
|
|
||||||
|
au.end_event("be_search");
|
||||||
Ok(entries)
|
Ok(entries)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -212,7 +217,6 @@ impl Clone for Backend {
|
||||||
fn clone(&self) -> Self {
|
fn clone(&self) -> Self {
|
||||||
// Make another Be and close the pool.
|
// Make another Be and close the pool.
|
||||||
Backend {
|
Backend {
|
||||||
log: self.log.clone(),
|
|
||||||
pool: self.pool.clone(),
|
pool: self.pool.clone(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -231,21 +235,25 @@ mod tests {
|
||||||
|
|
||||||
extern crate tokio;
|
extern crate tokio;
|
||||||
|
|
||||||
|
use super::super::audit::AuditEvent;
|
||||||
use super::super::entry::Entry;
|
use super::super::entry::Entry;
|
||||||
use super::super::filter::Filter;
|
use super::super::filter::Filter;
|
||||||
use super::super::log::{self, EventLog};
|
use super::super::log;
|
||||||
use super::{Backend, BackendError};
|
use super::{Backend, BackendError};
|
||||||
|
|
||||||
macro_rules! run_test {
|
macro_rules! run_test {
|
||||||
($test_fn:expr) => {{
|
($test_fn:expr) => {{
|
||||||
System::run(|| {
|
System::run(|| {
|
||||||
|
let mut audit = AuditEvent::new();
|
||||||
|
|
||||||
let test_log = log::start();
|
let test_log = log::start();
|
||||||
|
|
||||||
let be = Backend::new(test_log.clone(), "");
|
let be = Backend::new(&mut audit, "");
|
||||||
|
|
||||||
// Could wrap another future here for the future::ok bit...
|
// Could wrap another future here for the future::ok bit...
|
||||||
let fut = $test_fn(test_log, be);
|
let fut = $test_fn(&mut audit, be);
|
||||||
let comp_fut = fut.map_err(|()| ()).and_then(|r| {
|
let comp_fut = fut.map_err(|()| ()).and_then(move |_r| {
|
||||||
|
test_log.do_send(audit);
|
||||||
println!("Stopping actix ...");
|
println!("Stopping actix ...");
|
||||||
actix::System::current().stop();
|
actix::System::current().stop();
|
||||||
future::result(Ok(()))
|
future::result(Ok(()))
|
||||||
|
@ -258,11 +266,11 @@ mod tests {
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_simple_create() {
|
fn test_simple_create() {
|
||||||
run_test!(|log: actix::Addr<EventLog>, mut be: Backend| {
|
run_test!(|audit: &mut AuditEvent, mut be: Backend| {
|
||||||
log_event!(log, "Simple Create");
|
audit_log!(audit, "Simple Create");
|
||||||
|
|
||||||
let empty_result = be.create(&Vec::new());
|
let empty_result = be.create(audit, &Vec::new());
|
||||||
log_event!(log, "{:?}", empty_result);
|
audit_log!(audit, "{:?}", empty_result);
|
||||||
assert_eq!(empty_result, Err(BackendError::EmptyRequest));
|
assert_eq!(empty_result, Err(BackendError::EmptyRequest));
|
||||||
|
|
||||||
let mut e: Entry = Entry::new();
|
let mut e: Entry = Entry::new();
|
||||||
|
@ -270,14 +278,13 @@ mod tests {
|
||||||
.unwrap();
|
.unwrap();
|
||||||
assert!(e.validate());
|
assert!(e.validate());
|
||||||
|
|
||||||
let single_result = be.create(&vec![e]);
|
let single_result = be.create(audit, &vec![e]);
|
||||||
|
|
||||||
assert!(single_result.is_ok());
|
assert!(single_result.is_ok());
|
||||||
|
|
||||||
// Construct a filter
|
// Construct a filter
|
||||||
let filt = Filter::Pres(String::from("userid"));
|
let filt = Filter::Pres(String::from("userid"));
|
||||||
let entries = be.search(&filt).unwrap();
|
let entries = be.search(audit, &filt).unwrap();
|
||||||
println!("{:?}", entries);
|
|
||||||
|
|
||||||
// There should only be one entry so is this enough?
|
// There should only be one entry so is this enough?
|
||||||
assert!(entries.first().is_some());
|
assert!(entries.first().is_some());
|
||||||
|
@ -291,24 +298,24 @@ mod tests {
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_simple_search() {
|
fn test_simple_search() {
|
||||||
run_test!(|log: actix::Addr<EventLog>, be| {
|
run_test!(|audit: &mut AuditEvent, be| {
|
||||||
log_event!(log, "Simple Search");
|
audit_log!(audit, "Simple Search");
|
||||||
future::ok(())
|
future::ok(())
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_simple_modify() {
|
fn test_simple_modify() {
|
||||||
run_test!(|log: actix::Addr<EventLog>, be| {
|
run_test!(|audit: &mut AuditEvent, be| {
|
||||||
log_event!(log, "Simple Modify");
|
audit_log!(audit, "Simple Modify");
|
||||||
future::ok(())
|
future::ok(())
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_simple_delete() {
|
fn test_simple_delete() {
|
||||||
run_test!(|log: actix::Addr<EventLog>, be| {
|
run_test!(|audit: &mut AuditEvent, be| {
|
||||||
log_event!(log, "Simple Delete");
|
audit_log!(audit, "Simple Delete");
|
||||||
future::ok(())
|
future::ok(())
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
30
src/event.rs
30
src/event.rs
|
@ -11,9 +11,6 @@ pub enum EventResult {
|
||||||
Create,
|
Create,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug)]
|
|
||||||
pub struct RawSearchEvent {}
|
|
||||||
|
|
||||||
// At the top we get "event types" and they contain the needed
|
// At the top we get "event types" and they contain the needed
|
||||||
// actions, and a generic event component.
|
// actions, and a generic event component.
|
||||||
|
|
||||||
|
@ -21,8 +18,6 @@ pub struct RawSearchEvent {}
|
||||||
pub struct SearchEvent {
|
pub struct SearchEvent {
|
||||||
pub filter: Filter,
|
pub filter: Filter,
|
||||||
class: (), // String
|
class: (), // String
|
||||||
// It could be better to box this later ...
|
|
||||||
event: AuditEvent,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Message for SearchEvent {
|
impl Message for SearchEvent {
|
||||||
|
@ -34,10 +29,6 @@ impl SearchEvent {
|
||||||
SearchEvent {
|
SearchEvent {
|
||||||
filter: filter,
|
filter: filter,
|
||||||
class: (),
|
class: (),
|
||||||
event: AuditEvent {
|
|
||||||
time_start: (),
|
|
||||||
time_end: (),
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
// We need event -> some kind of json event string for logging
|
// We need event -> some kind of json event string for logging
|
||||||
|
@ -50,7 +41,6 @@ pub struct CreateEvent {
|
||||||
// input that we plan to parse.
|
// input that we plan to parse.
|
||||||
pub entries: Vec<Entry>,
|
pub entries: Vec<Entry>,
|
||||||
// It could be better to box this later ...
|
// It could be better to box this later ...
|
||||||
event: AuditEvent,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Message for CreateEvent {
|
impl Message for CreateEvent {
|
||||||
|
@ -59,24 +49,6 @@ impl Message for CreateEvent {
|
||||||
|
|
||||||
impl CreateEvent {
|
impl CreateEvent {
|
||||||
pub fn new(entries: Vec<Entry>) -> Self {
|
pub fn new(entries: Vec<Entry>) -> Self {
|
||||||
CreateEvent {
|
CreateEvent { entries: entries }
|
||||||
entries: entries,
|
|
||||||
event: AuditEvent {
|
|
||||||
time_start: (),
|
|
||||||
time_end: (),
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
// This structure tracks and event lifecycle, and is eventually
|
|
||||||
// sent to the logging system where it's structured and written
|
|
||||||
// out to the current logging BE.
|
|
||||||
#[derive(Debug)]
|
|
||||||
pub struct AuditEvent {
|
|
||||||
// vec of start/end points of various parts of the event?
|
|
||||||
// We probably need some functions for this. Is there a way in rust
|
|
||||||
// to automatically annotate line numbers of code?
|
|
||||||
time_start: (),
|
|
||||||
time_end: (),
|
|
||||||
}
|
|
||||||
|
|
|
@ -43,7 +43,7 @@ impl Filter {
|
||||||
|
|
||||||
// This is probably not safe, so it's for internal test cases
|
// This is probably not safe, so it's for internal test cases
|
||||||
// only because I'm familiar with the syntax ... you have been warned.
|
// only because I'm familiar with the syntax ... you have been warned.
|
||||||
fn from_ldap_string(ldap_string: String) -> Result<Self, ()> {
|
fn from_ldap_string(_ldap_string: String) -> Result<Self, ()> {
|
||||||
// For now return an empty filters
|
// For now return an empty filters
|
||||||
Ok(Filter::And(Vec::new()))
|
Ok(Filter::And(Vec::new()))
|
||||||
}
|
}
|
||||||
|
|
|
@ -20,8 +20,11 @@ extern crate uuid;
|
||||||
// This has to be before be so the import order works
|
// This has to be before be so the import order works
|
||||||
#[macro_use]
|
#[macro_use]
|
||||||
pub mod log;
|
pub mod log;
|
||||||
pub mod be;
|
#[macro_use]
|
||||||
|
mod audit;
|
||||||
|
mod be;
|
||||||
pub mod entry;
|
pub mod entry;
|
||||||
pub mod event;
|
pub mod event;
|
||||||
pub mod filter;
|
pub mod filter;
|
||||||
|
pub mod proto;
|
||||||
pub mod server;
|
pub mod server;
|
||||||
|
|
12
src/log.rs
12
src/log.rs
|
@ -1,4 +1,7 @@
|
||||||
use actix::prelude::*;
|
use actix::prelude::*;
|
||||||
|
use serde_json;
|
||||||
|
|
||||||
|
use super::audit::AuditEvent;
|
||||||
|
|
||||||
// Helper for internal logging.
|
// Helper for internal logging.
|
||||||
#[macro_export]
|
#[macro_export]
|
||||||
|
@ -57,6 +60,15 @@ impl Handler<LogEvent> for EventLog {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl Handler<AuditEvent> for EventLog {
|
||||||
|
type Result = ();
|
||||||
|
|
||||||
|
fn handle(&mut self, event: AuditEvent, _: &mut SyncContext<Self>) -> Self::Result {
|
||||||
|
let d = serde_json::to_string_pretty(&event).unwrap();
|
||||||
|
println!("AUDIT: {}", d);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
impl Handler<Event> for EventLog {
|
impl Handler<Event> for EventLog {
|
||||||
type Result = ();
|
type Result = ();
|
||||||
|
|
79
src/main.rs
79
src/main.rs
|
@ -3,24 +3,31 @@ extern crate serde_json;
|
||||||
// #[macro_use]
|
// #[macro_use]
|
||||||
extern crate actix;
|
extern crate actix;
|
||||||
extern crate actix_web;
|
extern crate actix_web;
|
||||||
|
extern crate bytes;
|
||||||
|
extern crate env_logger;
|
||||||
extern crate futures;
|
extern crate futures;
|
||||||
extern crate serde_derive;
|
extern crate serde_derive;
|
||||||
extern crate uuid;
|
extern crate uuid;
|
||||||
|
|
||||||
// use actix::prelude::*;
|
// use actix::prelude::*;
|
||||||
use actix_web::{
|
use actix_web::{
|
||||||
http, App, AsyncResponder, FutureResponse, HttpRequest, HttpResponse, Path, State,
|
error, http, middleware, App, AsyncResponder, Error, FutureResponse, HttpMessage, HttpRequest,
|
||||||
|
HttpResponse, Path, State,
|
||||||
};
|
};
|
||||||
|
|
||||||
use futures::Future;
|
use bytes::BytesMut;
|
||||||
|
use futures::{future, Future, Stream};
|
||||||
|
|
||||||
#[macro_use]
|
#[macro_use]
|
||||||
extern crate rsidm;
|
extern crate rsidm;
|
||||||
use rsidm::event;
|
use rsidm::event;
|
||||||
use rsidm::filter::Filter;
|
use rsidm::filter::Filter;
|
||||||
use rsidm::log;
|
use rsidm::log;
|
||||||
|
use rsidm::proto::SearchRequest;
|
||||||
use rsidm::server;
|
use rsidm::server;
|
||||||
|
|
||||||
|
const MAX_SIZE: usize = 262_144; //256k
|
||||||
|
|
||||||
struct AppState {
|
struct AppState {
|
||||||
qe: actix::Addr<server::QueryServer>,
|
qe: actix::Addr<server::QueryServer>,
|
||||||
}
|
}
|
||||||
|
@ -64,7 +71,53 @@ fn class_list((_name, state): (Path<String>, State<AppState>)) -> FutureResponse
|
||||||
.responder()
|
.responder()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Based on actix web example json
|
||||||
|
fn search(req: &HttpRequest<AppState>) -> Box<Future<Item = HttpResponse, Error = Error>> {
|
||||||
|
println!("{:?}", req);
|
||||||
|
// HttpRequest::payload() is stream of Bytes objects
|
||||||
|
req.payload()
|
||||||
|
.from_err()
|
||||||
|
// `fold` will asynchronously read each chunk of the request body and
|
||||||
|
// call supplied closure, then it resolves to result of closure
|
||||||
|
.fold(BytesMut::new(), move |mut body, chunk| {
|
||||||
|
// limit max size of in-memory payload
|
||||||
|
if (body.len() + chunk.len()) > MAX_SIZE {
|
||||||
|
Err(error::ErrorBadRequest("Request size too large."))
|
||||||
|
} else {
|
||||||
|
body.extend_from_slice(&chunk);
|
||||||
|
Ok(body)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
.and_then(|body| {
|
||||||
|
// body is loaded, now we can deserialize serde-json
|
||||||
|
// FIXME: THIS IS FUCKING AWFUL
|
||||||
|
let obj = serde_json::from_slice::<SearchRequest>(&body).unwrap();
|
||||||
|
// Dispatch a search
|
||||||
|
println!("{:?}", obj);
|
||||||
|
// We have to resolve this NOW else we break everything :(
|
||||||
|
/*
|
||||||
|
req.state().qe.send(
|
||||||
|
event::SearchEvent::new(obj.filter)
|
||||||
|
)
|
||||||
|
.from_err()
|
||||||
|
.and_then(|res| future::result(match res {
|
||||||
|
// What type is entry?
|
||||||
|
Ok(event::EventResult::Search { entries }) => Ok(HttpResponse::Ok().json(entries)),
|
||||||
|
Ok(_) => Ok(HttpResponse::Ok().into()),
|
||||||
|
// Can we properly report this?
|
||||||
|
Err(_) => Ok(HttpResponse::InternalServerError().into()),
|
||||||
|
}))
|
||||||
|
*/
|
||||||
|
Ok(HttpResponse::InternalServerError().into())
|
||||||
|
})
|
||||||
|
.responder()
|
||||||
|
}
|
||||||
|
|
||||||
fn main() {
|
fn main() {
|
||||||
|
// Configure the middleware logger
|
||||||
|
::std::env::set_var("RUST_LOG", "actix_web=info");
|
||||||
|
env_logger::init();
|
||||||
|
|
||||||
let sys = actix::System::new("rsidm-server");
|
let sys = actix::System::new("rsidm-server");
|
||||||
|
|
||||||
// read the config (if any?)
|
// read the config (if any?)
|
||||||
|
@ -75,10 +128,7 @@ fn main() {
|
||||||
// Start up the logging system: for now it just maps to stderr
|
// Start up the logging system: for now it just maps to stderr
|
||||||
let log_addr = log::start();
|
let log_addr = log::start();
|
||||||
|
|
||||||
// Starting the BE chooses the path.
|
// Start the query server with the given be path: future config
|
||||||
// let be_addr = be::start(log_addr.clone(), be::BackendType::SQLite, "test.db", 8);
|
|
||||||
|
|
||||||
// Start the query server with the given be
|
|
||||||
let server_addr = server::start(log_addr.clone(), "test.db", 8);
|
let server_addr = server::start(log_addr.clone(), "test.db", 8);
|
||||||
|
|
||||||
// start the web server
|
// start the web server
|
||||||
|
@ -87,12 +137,14 @@ fn main() {
|
||||||
qe: server_addr.clone(),
|
qe: server_addr.clone(),
|
||||||
})
|
})
|
||||||
// Connect all our end points here.
|
// Connect all our end points here.
|
||||||
// .middleware(middleware::Logger::default())
|
.middleware(middleware::Logger::default())
|
||||||
.resource("/", |r| r.f(index))
|
.resource("/", |r| r.f(index))
|
||||||
.resource("/{class_list}", |r| {
|
.resource("/search", |r| r.method(http::Method::POST).a(search))
|
||||||
|
// Add an ldap compat search function type?
|
||||||
|
.resource("/list/{class_list}", |r| {
|
||||||
r.method(http::Method::GET).with(class_list)
|
r.method(http::Method::GET).with(class_list)
|
||||||
})
|
})
|
||||||
.resource("/{class_list}/", |r| {
|
.resource("/list/{class_list}/", |r| {
|
||||||
r.method(http::Method::GET).with(class_list)
|
r.method(http::Method::GET).with(class_list)
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
@ -101,16 +153,9 @@ fn main() {
|
||||||
.start();
|
.start();
|
||||||
|
|
||||||
log_event!(log_addr, "Starting rsidm on http://127.0.0.1:8080");
|
log_event!(log_addr, "Starting rsidm on http://127.0.0.1:8080");
|
||||||
|
// curl --header "Content-Type: application/json" --request POST --data '{"name":"xyz","number":3}' http://127.0.0.1:8080/manual
|
||||||
|
|
||||||
// all the needed routes / views
|
// all the needed routes / views
|
||||||
|
|
||||||
let _ = sys.run();
|
let _ = sys.run();
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
|
||||||
mod tests {
|
|
||||||
#[test]
|
|
||||||
fn test_simple_create() {
|
|
||||||
println!("It works!");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
6
src/proto.rs
Normal file
6
src/proto.rs
Normal file
|
@ -0,0 +1,6 @@
|
||||||
|
use super::filter::Filter;
|
||||||
|
|
||||||
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
|
pub struct SearchRequest {
|
||||||
|
pub filter: Filter,
|
||||||
|
}
|
|
@ -1,22 +1,22 @@
|
||||||
use actix::prelude::*;
|
use actix::prelude::*;
|
||||||
|
|
||||||
|
use audit::AuditEvent;
|
||||||
use be::Backend;
|
use be::Backend;
|
||||||
use entry::Entry;
|
use entry::Entry;
|
||||||
use event::{CreateEvent, EventResult, SearchEvent};
|
use event::{CreateEvent, EventResult, SearchEvent};
|
||||||
use log::EventLog;
|
use log::EventLog;
|
||||||
|
|
||||||
pub fn start(
|
pub fn start(log: actix::Addr<EventLog>, path: &str, threads: usize) -> actix::Addr<QueryServer> {
|
||||||
log: actix::Addr<EventLog>,
|
let mut audit = AuditEvent::new();
|
||||||
// be: actix::Addr<BackendActor>,
|
audit.start_event("server_new");
|
||||||
path: &str,
|
|
||||||
threads: usize,
|
|
||||||
) -> actix::Addr<QueryServer> {
|
|
||||||
// Create the BE connection
|
// Create the BE connection
|
||||||
// probably need a config type soon ....
|
// probably need a config type soon ....
|
||||||
let be = Backend::new(log.clone(), path);
|
let be = Backend::new(&mut audit, path);
|
||||||
// now we clone it out in the startup I think
|
// now we clone it out in the startup I think
|
||||||
// Should the be need a log clone ref? or pass it around?
|
// Should the be need a log clone ref? or pass it around?
|
||||||
// it probably needs it ...
|
// it probably needs it ...
|
||||||
|
audit.end_event("server_new");
|
||||||
|
log.do_send(audit);
|
||||||
SyncArbiter::start(threads, move || QueryServer::new(log.clone(), be.clone()))
|
SyncArbiter::start(threads, move || QueryServer::new(log.clone(), be.clone()))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -46,8 +46,8 @@ impl QueryServer {
|
||||||
// Actually conduct a search request
|
// Actually conduct a search request
|
||||||
// This is the core of the server, as it processes the entire event
|
// This is the core of the server, as it processes the entire event
|
||||||
// applies all parts required in order and more.
|
// applies all parts required in order and more.
|
||||||
pub fn search(&mut self, se: &SearchEvent) -> Result<Vec<Entry>, ()> {
|
pub fn search(&mut self, au: &mut AuditEvent, se: &SearchEvent) -> Result<Vec<Entry>, ()> {
|
||||||
match self.be.search(&se.filter) {
|
match self.be.search(au, &se.filter) {
|
||||||
Ok(r) => Ok(r),
|
Ok(r) => Ok(r),
|
||||||
Err(_) => Err(()),
|
Err(_) => Err(()),
|
||||||
}
|
}
|
||||||
|
@ -56,11 +56,11 @@ impl QueryServer {
|
||||||
// What should this take?
|
// What should this take?
|
||||||
// This should probably take raw encoded entries? Or sohuld they
|
// This should probably take raw encoded entries? Or sohuld they
|
||||||
// be handled by fe?
|
// be handled by fe?
|
||||||
pub fn create(&mut self, ce: &CreateEvent) -> Result<(), ()> {
|
pub fn create(&mut self, au: &mut AuditEvent, ce: &CreateEvent) -> Result<(), ()> {
|
||||||
// Start a txn
|
// Start a txn
|
||||||
// Run any pre checks
|
// Run any pre checks
|
||||||
// We may change from ce.entries later to something else?
|
// We may change from ce.entries later to something else?
|
||||||
match self.be.create(&ce.entries) {
|
match self.be.create(au, &ce.entries) {
|
||||||
Ok(_) => Ok(()),
|
Ok(_) => Ok(()),
|
||||||
Err(_) => Err(()),
|
Err(_) => Err(()),
|
||||||
}
|
}
|
||||||
|
@ -82,20 +82,25 @@ impl Handler<SearchEvent> for QueryServer {
|
||||||
type Result = Result<EventResult, ()>;
|
type Result = Result<EventResult, ()>;
|
||||||
|
|
||||||
fn handle(&mut self, msg: SearchEvent, _: &mut Self::Context) -> Self::Result {
|
fn handle(&mut self, msg: SearchEvent, _: &mut Self::Context) -> Self::Result {
|
||||||
log_event!(self.log, "Begin event {:?}", msg);
|
let mut audit = AuditEvent::new();
|
||||||
|
audit.start_event("search");
|
||||||
|
audit_log!(audit, "Begin event {:?}", msg);
|
||||||
|
|
||||||
// Parse what we need from the event?
|
// Parse what we need from the event?
|
||||||
// What kind of event is it?
|
// What kind of event is it?
|
||||||
|
|
||||||
// In the future we'll likely change search event ...
|
// In the future we'll likely change search event ...
|
||||||
|
|
||||||
// was this ok?
|
// was this ok?
|
||||||
let res = match self.search(&msg) {
|
let res = match self.search(&mut audit, &msg) {
|
||||||
Ok(entries) => Ok(EventResult::Search { entries: entries }),
|
Ok(entries) => Ok(EventResult::Search { entries: entries }),
|
||||||
Err(e) => Err(e),
|
Err(e) => Err(e),
|
||||||
};
|
};
|
||||||
|
|
||||||
log_event!(self.log, "End event {:?}", msg);
|
audit_log!(audit, "End event {:?}", msg);
|
||||||
|
audit.end_event("search");
|
||||||
// At the end of the event we send it for logging.
|
// At the end of the event we send it for logging.
|
||||||
|
self.log.do_send(audit);
|
||||||
res
|
res
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -104,14 +109,19 @@ impl Handler<CreateEvent> for QueryServer {
|
||||||
type Result = Result<EventResult, ()>;
|
type Result = Result<EventResult, ()>;
|
||||||
|
|
||||||
fn handle(&mut self, msg: CreateEvent, _: &mut Self::Context) -> Self::Result {
|
fn handle(&mut self, msg: CreateEvent, _: &mut Self::Context) -> Self::Result {
|
||||||
log_event!(self.log, "Begin event {:?}", msg);
|
let mut audit = AuditEvent::new();
|
||||||
|
audit.start_event("create");
|
||||||
|
audit_log!(audit, "Begin create event {:?}", msg);
|
||||||
|
|
||||||
let res = match self.create(&msg) {
|
let res = match self.create(&mut audit, &msg) {
|
||||||
Ok(()) => Ok(EventResult::Create),
|
Ok(()) => Ok(EventResult::Create),
|
||||||
Err(e) => Err(e),
|
Err(e) => Err(e),
|
||||||
};
|
};
|
||||||
|
|
||||||
log_event!(self.log, "End event {:?}", msg);
|
audit_log!(audit, "End create event {:?}", msg);
|
||||||
|
audit.end_event("create");
|
||||||
|
// At the end of the event we send it for logging.
|
||||||
|
self.log.do_send(audit);
|
||||||
// At the end of the event we send it for logging.
|
// At the end of the event we send it for logging.
|
||||||
res
|
res
|
||||||
}
|
}
|
||||||
|
@ -130,6 +140,7 @@ mod tests {
|
||||||
|
|
||||||
extern crate tokio;
|
extern crate tokio;
|
||||||
|
|
||||||
|
use super::super::audit::AuditEvent;
|
||||||
use super::super::be::Backend;
|
use super::super::be::Backend;
|
||||||
use super::super::entry::Entry;
|
use super::super::entry::Entry;
|
||||||
use super::super::event::{CreateEvent, SearchEvent};
|
use super::super::event::{CreateEvent, SearchEvent};
|
||||||
|
@ -140,14 +151,16 @@ mod tests {
|
||||||
macro_rules! run_test {
|
macro_rules! run_test {
|
||||||
($test_fn:expr) => {{
|
($test_fn:expr) => {{
|
||||||
System::run(|| {
|
System::run(|| {
|
||||||
|
let mut audit = AuditEvent::new();
|
||||||
let test_log = log::start();
|
let test_log = log::start();
|
||||||
|
|
||||||
let be = Backend::new(test_log.clone(), "");
|
let be = Backend::new(&mut audit, "");
|
||||||
let test_server = QueryServer::new(test_log.clone(), be);
|
let test_server = QueryServer::new(test_log.clone(), be);
|
||||||
|
|
||||||
// Could wrap another future here for the future::ok bit...
|
// Could wrap another future here for the future::ok bit...
|
||||||
let fut = $test_fn(test_log, test_server);
|
let fut = $test_fn(test_log.clone(), test_server, &mut audit);
|
||||||
let comp_fut = fut.map_err(|()| ()).and_then(|_r| {
|
let comp_fut = fut.map_err(|()| ()).and_then(move |_r| {
|
||||||
|
test_log.do_send(audit);
|
||||||
println!("Stopping actix ...");
|
println!("Stopping actix ...");
|
||||||
actix::System::current().stop();
|
actix::System::current().stop();
|
||||||
future::result(Ok(()))
|
future::result(Ok(()))
|
||||||
|
@ -160,7 +173,7 @@ mod tests {
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_be_create_user() {
|
fn test_be_create_user() {
|
||||||
run_test!(|_log, mut server: QueryServer| {
|
run_test!(|_log, mut server: QueryServer, audit: &mut AuditEvent| {
|
||||||
let filt = Filter::Pres(String::from("userid"));
|
let filt = Filter::Pres(String::from("userid"));
|
||||||
|
|
||||||
let se1 = SearchEvent::new(filt.clone());
|
let se1 = SearchEvent::new(filt.clone());
|
||||||
|
@ -174,13 +187,13 @@ mod tests {
|
||||||
|
|
||||||
let ce = CreateEvent::new(expected.clone());
|
let ce = CreateEvent::new(expected.clone());
|
||||||
|
|
||||||
let r1 = server.search(&se1).unwrap();
|
let r1 = server.search(audit, &se1).unwrap();
|
||||||
assert!(r1.len() == 0);
|
assert!(r1.len() == 0);
|
||||||
|
|
||||||
let cr = server.create(&ce);
|
let cr = server.create(audit, &ce);
|
||||||
assert!(cr.is_ok());
|
assert!(cr.is_ok());
|
||||||
|
|
||||||
let r2 = server.search(&se2).unwrap();
|
let r2 = server.search(audit, &se2).unwrap();
|
||||||
assert!(r2.len() == 1);
|
assert!(r2.len() == 1);
|
||||||
|
|
||||||
assert_eq!(r2, expected);
|
assert_eq!(r2, expected);
|
||||||
|
|
Loading…
Reference in a new issue