From eed7c071567942efffc406107384b24a90142b4b Mon Sep 17 00:00:00 2001 From: Firstyear Date: Thu, 8 Aug 2024 12:02:02 +1000 Subject: [PATCH] Fix incorrect logic in cred update flow (#2956) Incorrect logic in cred update meant that valid transactions would not be allowed to commit as a mistake in the UI flow. This is a skill issue on my part. --- tools/cli/src/cli/person.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/cli/src/cli/person.rs b/tools/cli/src/cli/person.rs index 3a6a144ee..7a8d51e80 100644 --- a/tools/cli/src/cli/person.rs +++ b/tools/cli/src/cli/person.rs @@ -1470,10 +1470,11 @@ async fn credential_update_exec( Ok(status) => { if !status.can_commit { display_warnings(&status.warnings); + // Reset the loop + println!("Changes have NOT been saved."); + continue; } - // Reset the loop - println!("Changes have NOT been saved."); - continue; + // Can proceed } Err(e) => { eprintln!("An error occurred -> {:?}", e);