diff --git a/unix_integration/common/src/unix_config.rs b/unix_integration/common/src/unix_config.rs index d3a1bea2e..e47224635 100644 --- a/unix_integration/common/src/unix_config.rs +++ b/unix_integration/common/src/unix_config.rs @@ -558,28 +558,28 @@ impl UnixdConfig { #[derive(Debug)] /// This is the parsed configuration that will be used by pam/nss tools that need fast access to /// only the socket and timeout information related to the resolver. -pub struct KanidmUnixdConfig { +pub struct PamNssConfig { pub sock_path: String, // pub conn_timeout: u64, pub unix_sock_timeout: u64, } -impl Default for KanidmUnixdConfig { +impl Default for PamNssConfig { fn default() -> Self { - KanidmUnixdConfig::new() + PamNssConfig::new() } } -impl Display for KanidmUnixdConfig { +impl Display for PamNssConfig { fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { writeln!(f, "sock_path: {}", self.sock_path)?; writeln!(f, "unix_sock_timeout: {}", self.unix_sock_timeout) } } -impl KanidmUnixdConfig { +impl PamNssConfig { pub fn new() -> Self { - KanidmUnixdConfig { + PamNssConfig { sock_path: DEFAULT_SOCK_PATH.to_string(), unix_sock_timeout: DEFAULT_CONN_TIMEOUT * 2, } @@ -646,7 +646,7 @@ impl KanidmUnixdConfig { .unwrap_or(self.unix_sock_timeout); // Now map the values into our config. - Ok(KanidmUnixdConfig { + Ok(PamNssConfig { sock_path: config.sock_path.unwrap_or(self.sock_path), unix_sock_timeout, }) @@ -660,7 +660,7 @@ impl KanidmUnixdConfig { .map(|timeout| timeout * 2); // Now map the values into our config. - Ok(KanidmUnixdConfig { + Ok(PamNssConfig { sock_path: config.sock_path.unwrap_or(self.sock_path), unix_sock_timeout: kanidm_conn_timeout.unwrap_or(self.unix_sock_timeout), }) diff --git a/unix_integration/nss_kanidm/src/core.rs b/unix_integration/nss_kanidm/src/core.rs index d60ba9839..a59c58581 100644 --- a/unix_integration/nss_kanidm/src/core.rs +++ b/unix_integration/nss_kanidm/src/core.rs @@ -1,5 +1,5 @@ use kanidm_unix_common::client_sync::DaemonClientBlocking; -use kanidm_unix_common::unix_config::KanidmUnixdConfig; +use kanidm_unix_common::unix_config::PamNssConfig; use kanidm_unix_common::unix_passwd::{ read_etc_group_file, read_etc_passwd_file, EtcGroup, EtcUser, }; @@ -36,7 +36,7 @@ impl RequestOptions { fn connect_to_daemon(self) -> Source { match self { RequestOptions::Main { config_path } => { - let maybe_client = KanidmUnixdConfig::new() + let maybe_client = PamNssConfig::new() .read_options_from_optional_config(config_path) .ok() .and_then(|cfg| { diff --git a/unix_integration/pam_kanidm/src/core.rs b/unix_integration/pam_kanidm/src/core.rs index 79d3ea960..dd1ecf8ae 100644 --- a/unix_integration/pam_kanidm/src/core.rs +++ b/unix_integration/pam_kanidm/src/core.rs @@ -2,7 +2,7 @@ use crate::constants::PamResultCode; use crate::module::PamResult; use crate::pam::ModuleOptions; use kanidm_unix_common::client_sync::DaemonClientBlocking; -use kanidm_unix_common::unix_config::KanidmUnixdConfig; +use kanidm_unix_common::unix_config::PamNssConfig; use kanidm_unix_common::unix_passwd::{ read_etc_passwd_file, read_etc_shadow_file, EtcShadow, EtcUser, }; @@ -44,7 +44,7 @@ impl RequestOptions { fn connect_to_daemon(self) -> Source { match self { RequestOptions::Main { config_path } => { - let maybe_client = KanidmUnixdConfig::new() + let maybe_client = PamNssConfig::new() .read_options_from_optional_config(config_path) .ok() .and_then(|cfg| { diff --git a/unix_integration/pam_kanidm/src/pam/mod.rs b/unix_integration/pam_kanidm/src/pam/mod.rs index 0a40b1c25..6fb79a762 100755 --- a/unix_integration/pam_kanidm/src/pam/mod.rs +++ b/unix_integration/pam_kanidm/src/pam/mod.rs @@ -36,7 +36,7 @@ use std::convert::TryFrom; use std::ffi::CStr; use kanidm_unix_common::constants::DEFAULT_CONFIG_PATH; -use kanidm_unix_common::unix_config::KanidmUnixdConfig; +use kanidm_unix_common::unix_config::PamNssConfig; use crate::core::{self, RequestOptions}; use crate::pam::constants::*; @@ -50,8 +50,8 @@ use tracing_subscriber::filter::LevelFilter; use tracing_subscriber::fmt; use tracing_subscriber::prelude::*; -pub fn get_cfg() -> Result<KanidmUnixdConfig, PamResultCode> { - KanidmUnixdConfig::new() +pub fn get_cfg() -> Result<PamNssConfig, PamResultCode> { + PamNssConfig::new() .read_options_from_optional_config(DEFAULT_CONFIG_PATH) .map_err(|_| PamResultCode::PAM_SERVICE_ERR) } diff --git a/unix_integration/resolver/src/bin/kanidm-unix.rs b/unix_integration/resolver/src/bin/kanidm-unix.rs index b27424769..67c07ece1 100644 --- a/unix_integration/resolver/src/bin/kanidm-unix.rs +++ b/unix_integration/resolver/src/bin/kanidm-unix.rs @@ -18,7 +18,7 @@ use std::process::ExitCode; use clap::Parser; use kanidm_unix_common::client::DaemonClient; use kanidm_unix_common::constants::DEFAULT_CONFIG_PATH; -use kanidm_unix_common::unix_config::KanidmUnixdConfig; +use kanidm_unix_common::unix_config::PamNssConfig; use kanidm_unix_common::unix_proto::{ ClientRequest, ClientResponse, PamAuthRequest, PamAuthResponse, PamServiceInfo, }; @@ -28,8 +28,7 @@ include!("../opt/tool.rs"); macro_rules! setup_client { () => {{ - let Ok(cfg) = - KanidmUnixdConfig::new().read_options_from_optional_config(DEFAULT_CONFIG_PATH) + let Ok(cfg) = PamNssConfig::new().read_options_from_optional_config(DEFAULT_CONFIG_PATH) else { error!("Failed to parse {}", DEFAULT_CONFIG_PATH); return ExitCode::FAILURE; diff --git a/unix_integration/resolver/src/bin/kanidm_ssh_authorizedkeys.rs b/unix_integration/resolver/src/bin/kanidm_ssh_authorizedkeys.rs index e20ff3178..4878b7b37 100644 --- a/unix_integration/resolver/src/bin/kanidm_ssh_authorizedkeys.rs +++ b/unix_integration/resolver/src/bin/kanidm_ssh_authorizedkeys.rs @@ -19,7 +19,7 @@ use std::process::ExitCode; use clap::Parser; use kanidm_unix_common::client::DaemonClient; use kanidm_unix_common::constants::DEFAULT_CONFIG_PATH; -use kanidm_unix_common::unix_config::KanidmUnixdConfig; +use kanidm_unix_common::unix_config::PamNssConfig; use kanidm_unix_common::unix_proto::{ClientRequest, ClientResponse}; include!("../opt/ssh_authorizedkeys.rs"); @@ -44,8 +44,7 @@ async fn main() -> ExitCode { debug!("Starting authorized keys tool ..."); - let cfg = match KanidmUnixdConfig::new().read_options_from_optional_config(DEFAULT_CONFIG_PATH) - { + let cfg = match PamNssConfig::new().read_options_from_optional_config(DEFAULT_CONFIG_PATH) { Ok(c) => c, Err(e) => { error!("Failed to parse {}: {:?}", DEFAULT_CONFIG_PATH, e);